Page MenuHomeFreeBSD

Fix usage of angle-brackets and quotes in make(1) manpage
ClosedPublic

Authored by andrew_tao173.riddles.org.uk on Aug 29 2019, 8:37 PM.

Details

Reviewers
bcr
0mp
Group Reviewers
manpages
Summary

make(1) has commands .include <file> and .include "file", but the manpage was (inconsistently) rendering <file> with angle-brackets (e.g. in UTF8 output, ⟨file⟩ ) and "file" with curly-quotes in HTML output (but not text).

This is an attempt to fix that and output only literal <file> and "file" as is actually required in the makefile.

Test Plan

none

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

0mp accepted this revision.Feb 3 2020, 10:39 AM
0mp added a reviewer: bcr.
0mp added subscribers: bcr, 0mp.

Thanks for the patch! I've tested the HTML output and it looks much better now.

Can I commit it, @bcr?

This revision is now accepted and ready to land.Feb 3 2020, 10:39 AM
bcr added a comment.Feb 3 2020, 3:07 PM

This is in /contrib, so is bmake coming from another project or are we maintaining bmake these days? When the former is true, it would be good to send the patch upstream, so that we can get it from there without having to maintain it locally.