Fix qmath(3) with new GCC
ClosedPublic
Actions

Authored by trasz on Aug 27 2019, 6:30 PM.

Details

Reviewers

sef
asomers

Commits

rS351596: Fix qmath(3) build problems with GCC 8.

Summary

Fix build problems in qmath(3) with new GCC. Trivial, except for the signedness part in qmath.h.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Aug 27 2019, 6:30 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 27 2019, 6:30 PM

Harbormaster completed remote builds in B26139: Diff 61366.Aug 27 2019, 6:30 PM

trasz edited the summary of this revision. (Show Details)Aug 27 2019, 6:31 PM

trasz added reviewers: sef, asomers.Aug 27 2019, 6:36 PM

Note to self: tinderboxed.

lwhsu added a subscriber: lwhsu.Aug 28 2019, 1:57 PM

asomers added inline comments.Aug 28 2019, 2:54 PM

sys/sys/qmath.h
270 ↗	(On Diff #61366)	Technically, shouldn't you cast it _before_ inverting it? -(int64_t)(Q_ABS(iv) << Q_NFBITS(q))

Note that I'm committing it without waiting for a proper acceptance due to being a build fix.

sys/sys/qmath.h
270 ↗	(On Diff #61366)	Thanks; fixed.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2019, 7:39 AM

Closed by commit rS351596: Fix qmath(3) build problems with GCC 8. (authored by trasz). · Explain Why

This revision was automatically updated to reflect the committed changes.

trasz marked an inline comment as done.

trasz added a commit: rS351596: Fix qmath(3) build problems with GCC 8..

Revision Contents
Changeset List

Path

Size

head/

sys/

qmath.h

2 lines

tests/

sys/

qmath_test.c

16 lines

Diff 61445

View Options

head/sys/sys/qmath.h