Merge ping6 to ping
The front end code parses only -4 and -6 options, and decides whether to call ping or ping6.
Submitted by: Ján Sučan <firstname.lastname@example.org>
Sponsored by: Google LLC (Google Summer of Code 2019)
asomers on Aug 23 2019, 2:09 PM.Authored by
There are a very large number of changes, so older changes are hidden. Show Older Changes
Don't forget to add an entry to UPDATING and to ObsoleteFiles.inc
Now it doesn't even build:
/usr/home/somers/freebsd/base/head/sbin/ping/main.c:249:1: error: redefinition of 'main' main(int argc, char *argv) ^ /usr/home/somers/freebsd/base/head/sbin/ping/main.c:59:1: note: previous definition is here main(int argc, char *argv) ^ /usr/home/somers/freebsd/base/head/sbin/ping/main.c:331:1: error: redefinition of 'usage' usage(void) ^ /usr/home/somers/freebsd/base/head/sbin/ping/main.c:141:1: note: previous definition is here usage(void) ^ 2 errors generated.
Sorry, my bad. It's a side effect of arcanist. If you apply a patch, revert the directory, and reapply the patch, any newly created file gets doubled. You need to rm newly created files after "svn revert". I forgot to do that.
Arcanist won't let me update the review because of this bug: https://secure.phabricator.com/T10608 . But the required changes are small enough that I don't think they need additional review. There were a few related to rebasing. And there were a few changes required to fix the tests. I'll commit them if the tinderbox build passes.