This is modelled after the existing rwlock and sx probes. I also added
a lockmgr-disown probe.
Update lockstat(1) to report on the new probes. Fix a bug in the hold
events for sx locks.
Differential D21355
Add lockstat probes for lockmgr(9). markj on Aug 21 2019, 8:29 PM. Authored by Tags None Referenced Files
Subscribers
Details
This is modelled after the existing rwlock and sx probes. I also added Update lockstat(1) to report on the new probes. Fix a bug in the hold
Diff Detail
Event TimelineComment Actions The timing is a little funny as I'm working in the area and was considering adding these probes myself. I think the patch is fine with nits below taken care of. Note supposed fast path is now extra pessimized with presence of these probes (i.e. they get evaled after the lock is taken each time, for other routines lockstat enabled brings them to the slowpath first). I'll take care of this later.
Comment Actions I considered avoiding the fast path when probes are enabled, but didn't because the fast path is not inlined and the lockmgr_note_*() routines were too convenient.
Comment Actions I undestand, it's why I noted it's fine but will have to be taken care of later (which I'll do while refactoring this code). With the other remarks in place I think it's fine.
|