Page MenuHomeFreeBSD

Slightly simplify page queue code.
ClosedPublic

Authored by markj on Aug 20 2019, 2:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 1:29 PM
Unknown Object (File)
Jan 19 2024, 10:10 PM
Unknown Object (File)
Jan 16 2024, 2:46 AM
Unknown Object (File)
Jan 6 2024, 5:21 AM
Unknown Object (File)
Dec 22 2023, 2:16 AM
Unknown Object (File)
Dec 20 2023, 4:17 AM
Unknown Object (File)
Nov 25 2023, 6:39 PM
Unknown Object (File)
Oct 2 2023, 2:42 PM
Subscribers

Details

Summary
  • Add vm_pagequeue_remove(), which updates page queue state as required when removing a page.
  • Get rid of vm_page_pagequeue_lockptr(). When I added it I planned to use it more widely, but it is only used in vm_page_dequeue(). Modify vm_page_pagequeue() to handle a queue index of PQ_NONE, and use it instead. Make it local to vm_page.c; there are no external consumers and page queue management should be limited to vm_page.c and vm_pageout.c.

No functional change intended.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25985
Build 24540: arc lint + arc unit

Event Timeline

sys/vm/vm_page.c
3327

I'm not sure that I see the point of this assignment or the variable pq1, since the very first statement within this loop will replace the value assigned here.

  • Remove pq1.
  • Fix an assertion added in r338276. I meant to assert that either the page lock is held or that vm_page_dequeue() is being called from the page allocator. But testing m->order is not right, we have m->order == VM_NFREEORDER for any allocated page, so the assertion didn't really test anything.

Re-add pq1, and reload the page queue pointer only once if a mismatch
is detected after locking the page queue.

This revision is now accepted and ready to land.Aug 20 2019, 7:23 PM
This revision was automatically updated to reflect the committed changes.