Page MenuHomeFreeBSD

Identify emag 8180 CPU
ClosedPublic

Authored by tuexen on Aug 18 2019, 9:35 AM.

Details

Summary

Allow the emag 8180 CPU used in Ampere Computing systems to be identified. This is based on NetBSD as suggested in PR237055.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tuexen created this revision.Aug 18 2019, 9:35 AM

I tried a similar version of this change and my eMAG reports CPU 0: APM eMAG 8180 r3p2 affinity: 0 0

I used 'ampere' in the struct name and comments though.
https://github.com/emaste/freebsd/commit/d7bcf2058a7258fb89ef87f9e43604dec203cb3c

emaste accepted this revision.Aug 21 2019, 1:22 PM
This revision is now accepted and ready to land.Aug 21 2019, 1:22 PM
tuexen updated this revision to Diff 61286.Mon, Aug 26, 1:18 PM

Don't report APM and Ampere to be consistent with other entries. Also add comments to note that the CPU comes from Ampere even though using constants from Applied Micro.

This revision now requires review to proceed.Mon, Aug 26, 1:18 PM
tuexen added a comment.EditedMon, Aug 26, 1:21 PM

I tried a similar version of this change and my eMAG reports CPU 0: APM eMAG 8180 r3p2 affinity: 0 0
I used 'ampere' in the struct name and comments though.

I think not reporting APM and Ampere improves consistency. So I changed that. However, I left the apm in the structure names since it corresponds with the APM in the constant for the implementer constant and the implementer name. However, I added a comment to provide a hint that these CPUs are now managed by Ampere Computing.

https://github.com/emaste/freebsd/commit/d7bcf2058a7258fb89ef87f9e43604dec203cb3c

emaste accepted this revision.Mon, Aug 26, 2:45 PM

I think this is fine.

This revision is now accepted and ready to land.Mon, Aug 26, 2:45 PM
This revision was automatically updated to reflect the committed changes.