Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I tried a similar version of this change and my eMAG reports CPU 0: APM eMAG 8180 r3p2 affinity: 0 0
I used 'ampere' in the struct name and comments though.
https://github.com/emaste/freebsd/commit/d7bcf2058a7258fb89ef87f9e43604dec203cb3c
Don't report APM and Ampere to be consistent with other entries. Also add comments to note that the CPU comes from Ampere even though using constants from Applied Micro.
I think not reporting APM and Ampere improves consistency. So I changed that. However, I left the apm in the structure names since it corresponds with the APM in the constant for the implementer constant and the implementer name. However, I added a comment to provide a hint that these CPUs are now managed by Ampere Computing.
https://github.com/emaste/freebsd/commit/d7bcf2058a7258fb89ef87f9e43604dec203cb3c