Page MenuHomeFreeBSD

Add phys_avail allocation routines.
ClosedPublic

Authored by jeff on Aug 13 2019, 5:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 7:33 PM
Unknown Object (File)
Sat, Nov 23, 1:02 PM
Unknown Object (File)
Sat, Nov 23, 10:01 AM
Unknown Object (File)
Nov 17 2024, 4:33 PM
Unknown Object (File)
Nov 16 2024, 3:11 AM
Unknown Object (File)
Nov 14 2024, 5:41 AM
Unknown Object (File)
Nov 13 2024, 3:29 PM
Unknown Object (File)
Nov 7 2024, 9:04 AM
Subscribers

Details

Summary

This depends on https://reviews.freebsd.org/D21250

To implement a more intelligent early alloc I neded to be able to split phys_avail entries. This really could grow a little more encapsulation so there is less direct list manipulation elsewhere. The primary goal is to enable domain aware early allocation but I also think a little abstraction is nicer.

Some of this code came from Drew at netflix.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25847
Build 24418: arc lint + arc unit

Event Timeline

jeff retitled this revision from Add phys_avail processing routines. to Add phys_avail allocation routines..Aug 13 2019, 5:40 PM
jeff edited the summary of this revision. (Show Details)
jeff added reviewers: alc, markj, kib, gallatin.
gallatin added inline comments.
sys/vm/vm_phys.c
1635

Style nit .. I think these locals should be sorted alphabetically

1699

In the numa case, would it make sense to iterate to another domain rather than panic?

This revision is now accepted and ready to land.Aug 15 2019, 12:14 AM
kib added inline comments.
sys/vm/vm_phys.c
1604

phys_avail[i + 1] != 0

1642

dot at the end of the sentence

1668

Again, end the sentence with dot.

1672

!= 0

sys/vm/vm_phys.c
1699

I think that the startup memory we're allocating should be so small relative to domain memory that if we run into this it indicates another bug.