Page MenuHomeFreeBSD

lang/rust: Update to 1.37.0
ClosedPublic

Authored by tobik on Tue, Aug 13, 12:46 PM.

Details

Summary
Test Plan

Builds fine on 11.2/amd64 by @jbeich. Consumers ok too.
Builds fine on 12.0/amd64. Consumers ok too.
Builds fine on 11.2/i386. Consumers ok too.
Builds fine on 13.0/aarch64 per @greg_unrelenting.technology (thanks!). ripgrep ok.

As always a test build on tier 2 archs would be appreciated, @pkubaj, @mikael.urankar_gmail.com.

We should check that it does not suffer from the same problem as PR 239785 since the git2 crate seems to have been updated to 0.9.1... It seems to work fine.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tobik created this revision.Tue, Aug 13, 12:46 PM
tobik edited the test plan for this revision. (Show Details)Tue, Aug 13, 2:34 PM
tobik edited the test plan for this revision. (Show Details)Tue, Aug 13, 3:34 PM

I don't have access to my arm boards.

tobik added a comment.Tue, Aug 13, 4:58 PM

I don't have access to my arm boards.

Ok. Should we postpone the update a couple of days? Or no access to them for a longer time?

I don't have access to my arm boards.

Ok. Should we postpone the update a couple of days? Or no access to them for a longer time?

Don't wait for me, I'll have access to them next week but will be busy with other stuff.

tobik added a comment.Tue, Aug 13, 8:02 PM

@jbeich www/firefox-esr fails to build due to #![deny(warnings)] and the new default bare_trait_objects warning. See P296:

   Compiling webrender_bindings v0.1.0 (/wrkdirs/usr/ports/www/firefox-esr/work/firefox-60.8.0/gfx/webrender_bindings)
	error: trait objects without an explicit `dyn` are deprecated
	   --> gfx/webrender_bindings/src/bindings.rs:471:28
	    |
	471 |     fn clone(&self) -> Box<RenderNotifier> {
	    |                            ^^^^^^^^^^^^^^ help: use `dyn`: `dyn RenderNotifier`
	    |
	note: lint level defined here
	   --> gfx/webrender_bindings/src/lib.rs:5:9
	    |
	5   | #![deny(warnings)]
	    |         ^^^^^^^^
	    = note: #[deny(bare_trait_objects)] implied by #[deny(warnings)]
	
	error: trait objects without an explicit `dyn` are deprecated
	   --> gfx/webrender_bindings/src/bindings.rs:736:30
	    |
	736 |     let recorder: Option<Box<ApiRecordingReceiver>> = if unsafe { gfx_use_wrench() } {
	    |                              ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ApiRecordingReceiver`
	
	error: trait objects without an explicit `dyn` are deprecated
	  --> gfx/webrender_bindings/src/moz2d_renderer.rs:98:28
	   |
	98 |                resources: &BlobImageResources,
	   |                            ^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BlobImageResources`
	
	error: trait objects without an explicit `dyn` are deprecated
	   --> gfx/webrender_bindings/src/moz2d_renderer.rs:136:65
	    |
	136 |         fn process_fonts(mut extra_data: BufReader, resources: &BlobImageResources) {
	    |                                                                 ^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BlobImageResources`
	
	error: aborting due to 4 previous errors

Don't wait for me, I'll have access to them next week but will be busy with other stuff.

Alright, we'll deal with potential build problems afterwards then.

I'm building on aarch64 right now, llvm is done, so I'm expecting success

Builds fine on aarch64 CURRENT, tested building ripgrep with it, fine.

jbeich added a comment.EditedWed, Aug 14, 2:09 AM

@jbeich www/firefox-esr fails to build due to #![deny(warnings)] and the new default bare_trait_objects warning. See P296:

Fixed in rP508892.

tobik edited the test plan for this revision. (Show Details)Wed, Aug 14, 10:55 AM
tobik updated this revision to Diff 60778.Wed, Aug 14, 10:56 AM
  • Add cargo.mk and revision bumps
jbeich edited the test plan for this revision. (Show Details)Wed, Aug 14, 2:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rP508994: lang/rust: Update to 1.37.0 (authored by tobik). · Explain Why
This revision was automatically updated to reflect the committed changes.