Page MenuHomeFreeBSD

lang/rust: Update to 1.37.0
ClosedPublic

Authored by tobik on Aug 13 2019, 12:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 24, 1:37 PM
Unknown Object (File)
Dec 20 2023, 1:35 AM
Unknown Object (File)
Nov 25 2023, 12:01 AM
Unknown Object (File)
Nov 24 2023, 11:57 PM
Unknown Object (File)
Nov 24 2023, 11:57 PM
Unknown Object (File)
Nov 24 2023, 11:57 PM
Unknown Object (File)
Nov 24 2023, 5:25 PM
Unknown Object (File)
Nov 21 2023, 7:28 AM

Details

Summary
Test Plan

Builds fine on 11.2/amd64 by @jbeich. Consumers ok too.
Builds fine on 12.0/amd64. Consumers ok too.
Builds fine on 11.2/i386. Consumers ok too.
Builds fine on 13.0/aarch64 per @greg_unrelenting.technology (thanks!). ripgrep ok.

As always a test build on tier 2 archs would be appreciated, @pkubaj, @mikael.urankar_gmail.com.

We should check that it does not suffer from the same problem as PR 239785 since the git2 crate seems to have been updated to 0.9.1... It seems to work fine.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I don't have access to my arm boards.

In D21247#461898, @mikael.urankar_gmail.com wrote:

I don't have access to my arm boards.

Ok. Should we postpone the update a couple of days? Or no access to them for a longer time?

In D21247#461898, @mikael.urankar_gmail.com wrote:

I don't have access to my arm boards.

Ok. Should we postpone the update a couple of days? Or no access to them for a longer time?

Don't wait for me, I'll have access to them next week but will be busy with other stuff.

@jbeich www/firefox-esr fails to build due to #![deny(warnings)] and the new default bare_trait_objects warning. See P296:

   Compiling webrender_bindings v0.1.0 (/wrkdirs/usr/ports/www/firefox-esr/work/firefox-60.8.0/gfx/webrender_bindings)
	error: trait objects without an explicit `dyn` are deprecated
	   --> gfx/webrender_bindings/src/bindings.rs:471:28
	    |
	471 |     fn clone(&self) -> Box<RenderNotifier> {
	    |                            ^^^^^^^^^^^^^^ help: use `dyn`: `dyn RenderNotifier`
	    |
	note: lint level defined here
	   --> gfx/webrender_bindings/src/lib.rs:5:9
	    |
	5   | #![deny(warnings)]
	    |         ^^^^^^^^
	    = note: #[deny(bare_trait_objects)] implied by #[deny(warnings)]
	
	error: trait objects without an explicit `dyn` are deprecated
	   --> gfx/webrender_bindings/src/bindings.rs:736:30
	    |
	736 |     let recorder: Option<Box<ApiRecordingReceiver>> = if unsafe { gfx_use_wrench() } {
	    |                              ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ApiRecordingReceiver`
	
	error: trait objects without an explicit `dyn` are deprecated
	  --> gfx/webrender_bindings/src/moz2d_renderer.rs:98:28
	   |
	98 |                resources: &BlobImageResources,
	   |                            ^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BlobImageResources`
	
	error: trait objects without an explicit `dyn` are deprecated
	   --> gfx/webrender_bindings/src/moz2d_renderer.rs:136:65
	    |
	136 |         fn process_fonts(mut extra_data: BufReader, resources: &BlobImageResources) {
	    |                                                                 ^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BlobImageResources`
	
	error: aborting due to 4 previous errors
In D21247#462034, @mikael.urankar_gmail.com wrote:

Don't wait for me, I'll have access to them next week but will be busy with other stuff.

Alright, we'll deal with potential build problems afterwards then.

I'm building on aarch64 right now, llvm is done, so I'm expecting success

Builds fine on aarch64 CURRENT, tested building ripgrep with it, fine.

@jbeich www/firefox-esr fails to build due to #![deny(warnings)] and the new default bare_trait_objects warning. See P296:

Fixed in rP508892.

  • Add cargo.mk and revision bumps
This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2019, 2:30 PM
Closed by commit rP508994: lang/rust: Update to 1.37.0 (authored by tobik). · Explain Why
This revision was automatically updated to reflect the committed changes.