Page MenuHomeFreeBSD
Differential D21106

Capsicumize c++filt(1).
ClosedPublic
Actions

Authored by markj on Jul 29 2019, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 3:52 PM
Unknown Object (File)
Mar 10 2024, 3:48 PM
Unknown Object (File)
Mar 10 2024, 3:45 PM
Unknown Object (File)
Mar 10 2024, 3:45 PM
Unknown Object (File)
Mar 10 2024, 2:39 PM
Unknown Object (File)
Mar 10 2024, 2:32 PM
Unknown Object (File)
Mar 7 2024, 8:31 PM
Unknown Object (File)
Feb 7 2024, 9:37 PM
View All 47 Files
Subscribers
imp
jonathan

Details

Reviewers
oshogbo
emaste
Group Reviewers
capsicum
Commits
rS352907: Capsicumize c++filt(1).
Summary

C++ symbol demangling thankfully does not require any system
capabilities, so this one is easy.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25571
Build 24176: arc lint + arc unit

Event Timeline

markj created this revision.Jul 29 2019, 7:34 PM
Herald added a subscriber: jonathan. · View Herald TranscriptJul 29 2019, 7:34 PM
Harbormaster completed remote builds in B25571: Diff 60245.Jul 29 2019, 7:34 PM
markj added reviewers: capsicum, oshogbo, emaste.Jul 29 2019, 7:45 PM
oshogbo added inline comments.Jul 29 2019, 8:54 PM
contrib/elftoolchain/cxxfilt/cxxfilt.c
169

We don't want to limit stdin, stdout.

It funny. The only thing that needs cat pages is if the entering to capability mode will fail.
In other cases uses errx, warnx which I guess doesn't use NLA.
I guess we can just add it if something would change..

usr.bin/cxxfilt/Makefile
16

You are not using casper.

markj updated this revision to Diff 60255.Jul 29 2019, 9:11 PM

Don't need to define WITH_CASPER.

Harbormaster completed remote builds in B25578: Diff 60255.Jul 29 2019, 9:11 PM
markj updated this revision to Diff 60256.Jul 29 2019, 9:14 PM

Limit stdio rights.

Harbormaster completed remote builds in B25579: Diff 60256.Jul 29 2019, 9:14 PM
markj added a comment.Sep 24 2019, 4:03 PM

Are there any further comments on the diff?

emaste accepted this revision.Sep 27 2019, 1:20 PM
This revision is now accepted and ready to land.Sep 27 2019, 1:20 PM
Closed by commit rS352907: Capsicumize c++filt(1). (authored by markj). · Explain WhySep 30 2019, 4:10 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS352907: Capsicumize c++filt(1)..
Herald added a subscriber: imp. · View Herald TranscriptSep 30 2019, 4:10 PM

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
cxxfilt/
5 lines
usr.bin/
cxxfilt/
4 lines

Diff 60245

View Options

contrib/elftoolchain/cxxfilt/cxxfilt.c

Loading...
View Options

usr.bin/cxxfilt/Makefile

Loading...