Page MenuHomeFreeBSD

Capsicumize c++filt(1).
Needs ReviewPublic

Authored by markj on Jul 29 2019, 7:34 PM.

Details

Reviewers
oshogbo
emaste
Group Reviewers
capsicum
Summary

C++ symbol demangling thankfully does not require any system
capabilities, so this one is easy.

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25579
Build 24183: arc lint + arc unit

Event Timeline

markj created this revision.Jul 29 2019, 7:34 PM
oshogbo added inline comments.Jul 29 2019, 8:54 PM
contrib/elftoolchain/cxxfilt/cxxfilt.c
169–174

We don't want to limit stdin, stdout.

It funny. The only thing that needs cat pages is if the entering to capability mode will fail.
In other cases uses errx, warnx which I guess doesn't use NLA.
I guess we can just add it if something would change..

usr.bin/cxxfilt/Makefile
16 ↗(On Diff #60245)

You are not using casper.

markj updated this revision to Diff 60255.Jul 29 2019, 9:11 PM

Don't need to define WITH_CASPER.

markj updated this revision to Diff 60256.Jul 29 2019, 9:14 PM

Limit stdio rights.