Have pmap_fault() return success on a PF if the mapping is dirty.
ClosedPublic
Actions

Authored by markj on Jul 29 2019, 2:08 AM.

Details

Reviewers

manu
alc
andrew

Commits

rS350427: Have arm64's pmap_fault() handle WnR faults on dirty PTEs.

Test Plan

I added a printf to see if the new case is exercised; during a buildkernel,
ld.lld incurs roughly 150 permission faults on a dirty page.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 29 2019, 2:08 AM

Herald added a reviewer: manu. · View Herald TranscriptJul 29 2019, 2:08 AM

Herald added subscribers: emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B25558: Diff 60223.Jul 29 2019, 2:08 AM

markj edited the test plan for this revision. (Show Details)Jul 29 2019, 2:10 AM

markj added reviewers: alc, andrew.

I added a printf to see if the new case is exercised; during a buildkernel,
ld.lld incurs roughly 150 permission faults on a dirty page.

That's more than I would have guessed.

This revision is now accepted and ready to land.Jul 29 2019, 2:59 AM

alc added inline comments.Jul 29 2019, 3:46 AM

sys/arm64/arm64/pmap.c
5793 ↗	(On Diff #60223)	Btw, the trunc_page() here is redundant. You can simply pass "far".

Closed by commit rS350427: Have arm64's pmap_fault() handle WnR faults on dirty PTEs. (authored by markj). · Explain WhyJul 29 2019, 9:22 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS350427: Have arm64's pmap_fault() handle WnR faults on dirty PTEs..

Herald added a subscriber: imp. · View Herald TranscriptJul 29 2019, 9:22 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

pmap.c

21 lines

Diff 60257

View Options

head/sys/arm64/arm64/pmap.c

Have pmap_fault() return success on a PF if the mapping is dirty.ClosedPublicActions