Page MenuHomeFreeBSD

Fix epoch's use of turnstile_lock().
ClosedPublic

Authored by markj on Jul 24 2019, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 28, 4:35 PM
Unknown Object (File)
Sat, Sep 27, 3:01 PM
Unknown Object (File)
Sat, Sep 27, 11:04 AM
Unknown Object (File)
Sat, Sep 27, 10:13 AM
Unknown Object (File)
Sat, Sep 27, 9:16 AM
Unknown Object (File)
Sat, Sep 27, 8:26 AM
Unknown Object (File)
Fri, Sep 26, 2:52 AM
Unknown Object (File)
Aug 30 2025, 5:30 PM
Subscribers

Details

Summary

turnstile_lock() was added specifically for use in epoch. While waiting
for readers to drain, if the blocking thread discovers a reader blocked
on a turnstile, it will also block on the turnstile. It previously
returned the value of the ts_owner field to indicate that the turnstile
was successfully locked, and NULL to indicate that the race was lost.
But, ts_owner may be NULL if the turnstile corresponds to a rw lock
owned by one or more readers, in which case the epoch code leaked the
turnstile lock and chain lock.

Apply a minimal fix: simply return the owner as a separate value.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable