Page MenuHomeFreeBSD

Fix epoch's use of turnstile_lock().
ClosedPublic

Authored by markj on Jul 24 2019, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 19, 9:56 AM
Unknown Object (File)
Fri, Jan 3, 5:46 PM
Unknown Object (File)
Nov 1 2024, 9:54 AM
Unknown Object (File)
Sep 23 2024, 8:20 PM
Unknown Object (File)
Sep 23 2024, 4:35 AM
Unknown Object (File)
Sep 22 2024, 8:03 PM
Unknown Object (File)
Sep 21 2024, 11:50 PM
Unknown Object (File)
Sep 21 2024, 1:47 PM
Subscribers

Details

Summary

turnstile_lock() was added specifically for use in epoch. While waiting
for readers to drain, if the blocking thread discovers a reader blocked
on a turnstile, it will also block on the turnstile. It previously
returned the value of the ts_owner field to indicate that the turnstile
was successfully locked, and NULL to indicate that the race was lost.
But, ts_owner may be NULL if the turnstile corresponds to a rw lock
owned by one or more readers, in which case the epoch code leaked the
turnstile lock and chain lock.

Apply a minimal fix: simply return the owner as a separate value.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable