Differential D21013

Correct two errors in managing PGA_WRITEABLE
ClosedPublic
Actions

Authored by alc on Jul 21 2019, 3:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 13, 2:22 PM

	Unknown Object (File)
	Thu, Aug 13, 2:21 PM

	Unknown Object (File)
	Thu, Aug 13, 2:21 PM

	Unknown Object (File)
	Mon, Aug 10, 1:24 PM

	Unknown Object (File)
	Sat, Aug 8, 7:51 AM

	Unknown Object (File)
	Thu, Aug 6, 4:00 PM

	Unknown Object (File)
	Jun 20 2026, 9:08 AM

	Unknown Object (File)
	May 21 2026, 12:56 AM

Subscribers

Details

Reviewers

markj
manu

Commits

rS350202: With the introduction of software dirty bit emulation for managed mappings,

Summary

With the introduction of software dirty bit emulation for managed mappings, we should test ATTR_SW_DBM, not ATTR_AP_RW, to determine whether to set PGA_WRITEABLE. At present, we are are setting PGA_WRITEABLE based on whether the dirty bit is preset, not whether the mapping is writeable.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc created this revision.Jul 21 2019, 3:57 PM

Herald added subscribers: emaste, andrew. · View Herald TranscriptJul 21 2019, 3:57 PM

alc edited the summary of this revision. (Show Details)Jul 21 2019, 3:58 PM

markj accepted this revision.Jul 21 2019, 4:33 PM

This revision is now accepted and ready to land.Jul 21 2019, 4:33 PM

Closed by commit rS350202: With the introduction of software dirty bit emulation for managed mappings, (authored by alc). · Explain WhyJul 21 2019, 5:00 PM

This revision was automatically updated to reflect the committed changes.

alc added a commit: rS350202: With the introduction of software dirty bit emulation for managed mappings,.

Herald added a reviewer: manu. · View Herald TranscriptJul 21 2019, 5:00 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

arm64/

4 lines

Diff 59990

head/sys/arm64/arm64/pmap.c

Loading...