Fix test for lib/libc/net/servent_test

[olivier]

Summary

One test is always skipped because it required inexistent /var/db/services.cdb: Replacing by services.db fix the test.

Test Plan

Before patch:

root@fb:/usr/tests # kyua test lib/libc/net/servent_test
lib/libc/net/servent_test:servent  ->  skipped: Required file '/var/db/services.cdb' not found  [0.001s]

Results file id is usr_tests.20190712-222013-284112
Results saved to /root/.kyua/store/results.usr_tests.20190712-222013-284112.db

1/1 passed (0 failed)

After the patch:

root@fbsd:/usr/tests # kyua test lib/libc/net/servent_test
lib/libc/net/servent_test:servent  ->  passed  [0.117s]

Results file id is usr_tests.20190712-222045-982234
Results saved to /root/.kyua/store/results.usr_tests.20190712-222045-982234.db

1/1 passed (0 failed)

[ngie]

Good eye!

Could you please adjust the script from the Makefile so this script doesn’t need to diverge from upstream?

[olivier]

In D20943#453979, @ngie wrote:

Good eye!

Could you please adjust the script from the Makefile so this script doesn’t need to diverge from upstream?

What do you man by adjusting the script from the Makefile ?
Do you mean modifying lib/libc/tests/net/Makefile to add an action to rename services.cdb ?

[ngie]

In D20943#454106, @olivier wrote:

In D20943#453979, @ngie wrote:

Good eye!

Could you please adjust the script from the Makefile so this script doesn’t need to diverge from upstream?

What do you man by adjusting the script from the Makefile ?
Do you mean modifying lib/libc/tests/net/Makefile to add an action to rename services.cdb ?

Yes.

Some decent examples for how I did this with the tmpfs tests from NetBSD can be found in tests/sys/fs/tmpfs/Makefile. My goal was to leave the tmpfs testcases as untouched as possible so we could pull in future netbsd-tests snapshots with a little porting/hacking as possible :).

[olivier]

Update following Enji's advice.

[ngie]