Differential D20884

Return an error if a matching resource is not found.
ClosedPublic
Actions

Authored by markj on Jul 8 2019, 11:10 PM.

Details

Reviewers

jchandra
andrew
manu

Commits

rS351867: pcie: return an error if a matching resource is not found

Summary

I am hitting this on the Cavium ThunderX during boot when the ThunderX
MDIO driver tries to attach. We fail to activate a memory resource, but
the method returns success anyway, leading to a data abort shortly
after.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 8 2019, 11:10 PM

Harbormaster completed remote builds in B25257: Diff 59556.Jul 8 2019, 11:10 PM

markj added reviewers: jchandra, andrew, manu.Jul 8 2019, 11:10 PM

Ping?

manu accepted this revision.Jul 17 2019, 3:57 PM

This revision is now accepted and ready to land.Jul 17 2019, 3:57 PM

markj added inline comments.Jul 17 2019, 5:14 PM

sys/dev/pci/pci_host_generic.c
369 ↗	(On Diff #59556)	Shouldn't it be using rman_get_end() in the second part of this condition?

Closed by commit rS351867: pcie: return an error if a matching resource is not found (authored by emaste). · Explain WhySep 5 2019, 3:45 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS351867: pcie: return an error if a matching resource is not found.

Herald added a subscriber: imp. · View Herald TranscriptSep 5 2019, 3:45 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

pci/

pci_host_generic.c

2 lines

Diff 61694

View Options

head/sys/dev/pci/pci_host_generic.c

Return an error if a matching resource is not found.ClosedPublicActions