Page MenuHomeFreeBSD

Return an error if a matching resource is not found.
ClosedPublic

Authored by markj on Jul 8 2019, 11:10 PM.

Details

Summary

I am hitting this on the Cavium ThunderX during boot when the ThunderX
MDIO driver tries to attach. We fail to activate a memory resource, but
the method returns success anyway, leading to a data abort shortly
after.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.Jul 8 2019, 11:10 PM
manu accepted this revision.Jul 17 2019, 3:57 PM
This revision is now accepted and ready to land.Jul 17 2019, 3:57 PM
markj added inline comments.Jul 17 2019, 5:14 PM
sys/dev/pci/pci_host_generic.c
369 ↗(On Diff #59556)

Shouldn't it be using rman_get_end() in the second part of this condition?

This revision was automatically updated to reflect the committed changes.