Differential D20867

Document atomicity for read(2) and write(2).
ClosedPublic
Actions

Authored by kib on Jul 6 2019, 5:29 PM.

Details

Reviewers

asomers
rmacklem
emaste

Group Reviewers

manpages

Commits

rS349794: Document atomicity for read(2) and write(2).

Summary

Take part of the text from POSIX 2018 edition and describe the atomicity requirements for read and write syscalls. See p1003.1-2018, Vol.2, 2.9.7 Threads interaction with Regular File Operations.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jul 6 2019, 5:29 PM

Herald added a reviewer: manpages. · View Herald TranscriptJul 6 2019, 5:29 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B25222: Diff 59474.Jul 6 2019, 5:29 PM

asomers added inline comments.Jul 6 2019, 7:21 PM

lib/libc/sys/read.2
132 ↗	(On Diff #59474)	It looks like the year 2004 edition included this language, too.
144 ↗	(On Diff #59474)	each call shall either see

kib marked an inline comment as done.Jul 6 2019, 7:38 PM

kib added inline comments.

lib/libc/sys/read.2
144 ↗	(On Diff #59474)	From what I remember, we do not use 'shall' in man pages, because we describe the implementation and not a requirement for the implementation.

Ref year 2004 edition.

Harbormaster completed remote builds in B25225: Diff 59479.Jul 6 2019, 7:39 PM

asomers added inline comments.Jul 6 2019, 7:46 PM

lib/libc/sys/read.2
144 ↗	(On Diff #59474)	Fair enough, but the sentence as you wrote it is not grammatically correct. "see" needs to be conjugated for tense. Using "shall" or "will" would fix that.