Page MenuHomeFreeBSD
Differential D20847

fix style(9) violations involving division by PAGE_SIZE
ClosedPublic
Actions

Authored by dougm on Jul 3 2019, 11:02 PM.
Tags
None
Referenced Files
F132489875: D20847.id59376.diff
Fri, Oct 17, 8:45 AM
F132489874: D20847.id59381.diff
Fri, Oct 17, 8:45 AM
F132489873: D20847.id.diff
Fri, Oct 17, 8:45 AM
F132489869: D20847.id59469.diff
Fri, Oct 17, 8:45 AM
F132438192: D20847.diff
Thu, Oct 16, 11:00 PM
Unknown Object (File)
Tue, Sep 30, 3:47 PM
Unknown Object (File)
Sep 13 2025, 1:02 AM
Unknown Object (File)
Aug 6 2025, 4:56 AM
View All 88 Files
Subscribers
cem
imp

Details

Reviewers
alc
kib
markj
Commits
rS349791: Fix style(9) violations involving division by PAGE_SIZE.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm created this revision.Jul 3 2019, 11:02 PM
dougm updated this revision to Diff 59381.Jul 4 2019, 2:25 AM
dougm retitled this revision from fix style(9) violations in swap_pager.c to fix style(9) violations involving division by PAGE_SIZE.

Include other files.

alc accepted this revision.Jul 6 2019, 3:41 PM
alc added reviewers: kib, markj.
This revision is now accepted and ready to land.Jul 6 2019, 3:41 PM
markj accepted this revision.Jul 6 2019, 3:41 PM
Closed by commit rS349791: Fix style(9) violations involving division by PAGE_SIZE. (authored by dougm). · Explain WhyJul 6 2019, 3:55 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rS349791: Fix style(9) violations involving division by PAGE_SIZE..
Herald added a subscriber: imp. · View Herald TranscriptJul 6 2019, 3:55 PM
cem added a subscriber: cem.Jul 6 2019, 5:02 PM
cem added inline comments.
head/sys/vm/swap_pager.c
526

The parentheses should not have been removed here.

alc added inline comments.Jul 6 2019, 5:24 PM
head/sys/vm/swap_pager.c
526

Conrad, how about changing the wording here to, "... array, which has MAXPHYS / PAGE_SIZE entries, and ..."?

cem added inline comments.Jul 6 2019, 10:15 PM
head/sys/vm/swap_pager.c
526

Alan, that sounds good to me, thanks!

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
4 lines
2 lines
4 lines

Diff 59469

View Options

head/sys/vm/swap_pager.c

Loading...
View Options

head/sys/vm/vm_pageout.c

Loading...
View Options

head/sys/vm/vnode_pager.c

Loading...