aarch64: expose esr in mcontext
Needs ReviewPublic
Actions

Authored by val_packett.cool on Jul 2 2019, 9:25 PM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Sep 10, 6:07 PM

	Unknown Object (File)
	Tue, Sep 8, 1:46 AM

	Unknown Object (File)
	Sat, Sep 5, 3:36 AM

	Unknown Object (File)
	Fri, Sep 4, 4:30 PM

	Unknown Object (File)
	Fri, Sep 4, 1:17 AM

	Unknown Object (File)
	Thu, Sep 3, 9:04 AM

	Unknown Object (File)
	Thu, Sep 3, 3:20 AM

	Unknown Object (File)
	Thu, Sep 3, 2:09 AM

Subscribers

Details

Reviewers

andrew
manu

Group Reviewers

arm64
Contributor Reviews (src)

Summary

https://reviews.llvm.org/D32172 — looks like this was planned back in 2017 but the whole ASan thing ended up abandoned for some reason.. :(

Test Plan

My build of ASan that uses this field works, but what specifically should I test with the sanitizers that would depend on this register thing??

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

ping? anyone?

zlei added inline comments.

sys/arm64/include/ucontext.h
42	This conflicts with https://reviews.freebsd.org/D38983 , and certainly will break ABI. I'm not expert on arm64. Maybe new registers should contract with `struct arm64_reg_context` ? See https://reviews.freebsd.org/D43302 .