Page MenuHomeFreeBSD

aarch64: expose esr in mcontext
Needs ReviewPublic

Authored by val_packett.cool on Jul 2 2019, 9:25 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Jul 4, 5:45 AM
Unknown Object (File)
Tue, Jun 30, 7:05 PM
Unknown Object (File)
Sat, Jun 27, 5:27 AM
Unknown Object (File)
Fri, Jun 26, 11:42 PM
Unknown Object (File)
Wed, Jun 24, 3:10 AM
Unknown Object (File)
Mon, Jun 22, 6:41 PM
Unknown Object (File)
May 17 2026, 3:32 PM
Unknown Object (File)
May 17 2026, 9:13 AM
Subscribers

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Contributor Reviews (src)
Summary

https://reviews.llvm.org/D32172 — looks like this was planned back in 2017 but the whole ASan thing ended up abandoned for some reason.. :(

Test Plan

My build of ASan that uses this field works, but what specifically should I test with the sanitizers that would depend on this register thing??

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei added inline comments.
sys/arm64/include/ucontext.h
42

This conflicts with https://reviews.freebsd.org/D38983 , and certainly will break ABI.

I'm not expert on arm64. Maybe new registers should contract with struct arm64_reg_context ? See https://reviews.freebsd.org/D43302 .