Page MenuHomeFreeBSD

aarch64: expose esr in mcontext
Needs ReviewPublic

Authored by val_packett.cool on Jul 2 2019, 9:25 PM.
Tags
Referenced Files
F174713353: D20838.id59328.diff
Mon, Oct 5, 10:22 AM
Unknown Object (File)
Sun, Oct 4, 2:43 PM
Unknown Object (File)
Thu, Oct 1, 10:26 AM
Unknown Object (File)
Thu, Sep 24, 9:49 AM
Unknown Object (File)
Fri, Sep 18, 3:51 PM
Unknown Object (File)
Thu, Sep 10, 6:07 PM
Unknown Object (File)
Tue, Sep 8, 1:46 AM
Unknown Object (File)
Sep 5 2026, 3:36 AM
Subscribers

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Contributor Reviews (src)
Summary

https://reviews.llvm.org/D32172 — looks like this was planned back in 2017 but the whole ASan thing ended up abandoned for some reason.. :(

Test Plan

My build of ASan that uses this field works, but what specifically should I test with the sanitizers that would depend on this register thing??

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei added inline comments.
sys/arm64/include/ucontext.h
42

This conflicts with https://reviews.freebsd.org/D38983 , and certainly will break ABI.

I'm not expert on arm64. Maybe new registers should contract with struct arm64_reg_context ? See https://reviews.freebsd.org/D43302 .