Differential D20775

Add missing ACPI GICv2 MSI/MSI-X attachment
ClosedPublic
Actions

Authored by val_packett.cool on Jun 26 2019, 8:47 PM.

Details

Reviewers

bcran
mw

Group Reviewers

arm64

Commits

rS349493: Add missing ACPI GICv2 MSI/MSI-X attachment

Summary

This lets PCIe MSI-X device interrupts work on the MACCHIATObin (Marvell Armada 8k), which allows e.g. the Intel igb NIC to fully work :)

(idk why, but the card did not receive packets at all with the legacy interrupt it was falling back to)

Test Plan

(if anyone wants to test for themselves on a mcbin, you currently need to remove the ECAM shift in the ACPI tables)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Jun 26 2019, 8:47 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptJun 26 2019, 8:47 PM

val_packett.cool edited the test plan for this revision. (Show Details)Jun 26 2019, 8:51 PM

val_packett.cool added a subscriber: mw.

val_packett.cool retitled this revision from Add missing ACPI GICv2 MSI/MSI-X support to Add missing ACPI GICv2 MSI/MSI-X attachment.Jun 26 2019, 8:54 PM

mw accepted this revision.Jun 27 2019, 6:22 AM

This revision is now accepted and ready to land.Jun 27 2019, 6:22 AM

bcran accepted this revision as: bcran.Jun 28 2019, 1:14 AM

Closed by commit rS349493: Add missing ACPI GICv2 MSI/MSI-X attachment (authored by bcran). · Explain WhyJun 28 2019, 1:17 AM

This revision was automatically updated to reflect the committed changes.

bcran added a commit: rS349493: Add missing ACPI GICv2 MSI/MSI-X attachment.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm/

gic_acpi.c

12 lines

Diff 59142

View Options

head/sys/arm/arm/gic_acpi.c

Add missing ACPI GICv2 MSI/MSI-X attachmentClosedPublicActions