Page MenuHomeFreeBSD

Avoid .debug_str lookups.
ClosedPublic

Authored by markj on Jun 25 2019, 4:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 31 2024, 3:17 PM
Unknown Object (File)
Oct 31 2024, 4:34 AM
Unknown Object (File)
Oct 31 2024, 4:33 AM
Unknown Object (File)
Oct 31 2024, 4:21 AM
Unknown Object (File)
Oct 26 2024, 11:11 PM
Unknown Object (File)
Oct 19 2024, 2:08 PM
Unknown Object (File)
Oct 18 2024, 5:11 PM
Unknown Object (File)
Oct 14 2024, 11:57 PM
Subscribers

Details

Summary

libdwarf caches a string table handle, use that instead. This provides
a noticeable speedup when iterating through DIEs, since we would
otherwise do a linear search of all of the DWARF sections looking for
".debug_str" using strcmp().

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 25039
Build 23753: arc lint + arc unit

Event Timeline

Presumably _dwarf_strtab_init is guaranteed to be called?

Presumably _dwarf_strtab_init is guaranteed to be called?

The only way it won't be called is if an earlier error occurs during initialization. If there is no string table, then the assertion in the removed code would fail.

This revision is now accepted and ready to land.Jun 25 2019, 7:58 PM