Add new port: net/tcprtt: reliably measure the TCP handshake round trip time using stats(9)

[trasz]

Summary

Add new port: net/tcprtt

The tcprtt utility reliably measures the TCP handshake round trip time
using the new stats(3) statistics framework.

Note that this depends on https://reviews.freebsd.org/D20655.

Sponsored By: Klara Inc, Netflix
Obtained from: Netflix

[matthew]

I'm getting compilation failures due to missing sys/qmath.h on 12.0 and 11.2

tcprtt.c:32:10: fatal error: 'sys/qmath.h' file not found
#include <sys/qmath.h>
         ^~~~~~~~~~~~~
1 error generated.
*** [tcprtt.o] Error code 1

make[1]: stopped in /wrkdirs/usr/ports/net/tcprtt/work/tcprtt-1.0
1 error

make[1]: stopped in /wrkdirs/usr/ports/net/tcprtt/work/tcprtt-1.0

net/tcprtt/files/Makefile

1 ↗

(On Diff #58672)

I'm wondering about the split of actions between this Makefile and the ports Makefile. It seems odd to have the
build stage controlled here, but the install stage from elsewhere.

[matthew]

Given this:

Note that this depends on https://reviews.freebsd.org/D20655.

Presumably this port will be limited to CURRENT once D20655 gets committed, and then waiting on MFC to a release branch
before it can be packaged for wider distribution? I'm not sure about adding a port that only works on CURRENT. That's
a question for portmgr@

However it should have tests against ${OSVERSION} to ensure we don't waste time trying to build it on OS versions where
it is never going to work...

[mat]

The source files should not be put in the "files" directory, if one day you need to add support files, like *.in files, it will clutter everything. It would be preferable to put them in a src directory.

[trasz]

Move sources to GitHub, add __FreeBSD_version check.

Since I don't know what the version will be, the number
will probably change before committing.

[trasz]

Fix build with upstreamed changes.

[trasz]

Update after fix from thj@.

[allanjude]

net/tcprtt/Makefile

21

stats.h is committed now, so we should update this to the correct number

[trasz]

net/tcprtt/Makefile

21

This also needs the TCP part of the stats(3) framework, which is not committed yet.