Page MenuHomeFreeBSD

mpsutil slot set status
ClosedPublic

Authored by avg on Jun 6 2019, 2:58 PM.

Details

Summary

This code has been written as a proof of concept, but I think that it
can be useful in general. It allows to set the status of an enclosure
slot. Practically, this means controlling whatever slot status LEDs the
enclosure provides. At present, the new command does not have sanity
checks or any conveniences. That means that it is possible to issue
the command for an invalid slot and an enclosure. But the worst I have
seen happening is either the command failing or simply being ignored.
Also, at the moment, the status has to be specified as a numeric bit
mask. The bit definitions can be found in sys/dev/mps/mpi/mpi2_init.h,
they are prefixed with MPI2_SEP_REQ_SLOTSTATUS_. The only way to
address a slot is by the enclosure handle and the slot number. Both are
readily available from mpsutil show commands.

So, future enhancements could include alternative ways to address a slot
(e.g., by a disk handle or a disk device name) and human friendly names
for slot statuses.

The new command is useful alternative to 'sas2ircu locate' command.
First, sas2ircu is a proprietary blob. Second, it supports setting only
locate / identify status bit.

Test Plan

Tested on HP H220 running LSI IT firmware 20.x.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

avg created this revision.Jun 6 2019, 2:58 PM
bapt accepted this revision.Wed, Sep 4, 6:35 AM

LGTM at quick glance, note that I do not have access to any hardware anymore to test.

This revision is now accepted and ready to land.Wed, Sep 4, 6:35 AM
This revision was automatically updated to reflect the committed changes.