Page MenuHomeFreeBSD

Keep the shadow PCIR_COMMAND synced with the real one for pass through.
ClosedPublic

Authored by jhb on Jun 5 2019, 11:00 PM.
Tags
None
Referenced Files
F103564102: D20531.diff
Tue, Nov 26, 2:00 PM
Unknown Object (File)
Fri, Nov 22, 8:55 PM
Unknown Object (File)
Fri, Nov 22, 6:09 PM
Unknown Object (File)
Fri, Nov 22, 7:39 AM
Unknown Object (File)
Thu, Nov 21, 1:13 AM
Unknown Object (File)
Sun, Nov 17, 1:18 PM
Unknown Object (File)
Mon, Nov 11, 3:55 AM
Unknown Object (File)
Sun, Nov 10, 6:34 PM
Subscribers

Details

Summary

This ensures that bhyve properly recognizes when decoding is disabled for
BARs on passthru devices. To properly handle writes to the register,
export a pci_emul_cmd_changed function from pci_emul.c that the pass
through device model invokes for config writes that change PCIR_COMMAND.

Test Plan
  • Nick Principe tested this and it fixed his issue with Windows 10 and a pass through NIC

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24710
Build 23475: arc lint + arc unit

Event Timeline

Looks like diff has gotten really confused by something making this very hard to see what it is that really changed since we are seeing function
pci_emul_cmdsts_write
compared to a new function
pci_emul_cmd_changed and are not actually seeing what changed in
pci_emul_cmdsts_write

Anyway to regenerate this in a way that makes it reviewable? never mind, looking at the raw diff it is clear as a bell, what Phabricator is doing is a mess.

This revision is now accepted and ready to land.Jun 6 2019, 1:08 AM
This revision was automatically updated to reflect the committed changes.