Differential D20530

Enable memory and I/O decoding in PCI devices on demand.
ClosedPublic
Actions

Authored by jhb on Jun 5 2019, 10:36 PM.

Details

Reviewers

rgrimes

Group Reviewers

bhyve

Commits

rS348778: Enable memory and I/O decoding in PCI devices on demand.

Summary

Rather than uncoditionally setting the MEMEN and PORTEN bits in
PCIR_COMMAND for PCI devices, set the respective bit when the first
BAR of a given type is added to the device. This more closely matches
what firmware does on bare metal.

BUSMASTEREN is still set unconditionally. Eventually this bit should
move into the device models as not all device models need this set.

Test Plan

booted a guest and verified hostb and isab devices now don't have either MEMEN or PORTEN enabled, but virtio devices still have both set

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 24709
Build 23474: arc lint + arc unit

Event Timeline

jhb created this revision.Jun 5 2019, 10:36 PM

Herald added subscribers: bcran, rgrimes. · View Herald TranscriptJun 5 2019, 10:36 PM

Harbormaster completed remote builds in B24709: Diff 58285.Jun 5 2019, 10:36 PM

rgrimes accepted this revision as: rgrimes.Jun 6 2019, 12:59 AM

rgrimes added inline comments.

usr.sbin/bhyve/pci_emul.c
589	Order of locals

This revision is now accepted and ready to land.Jun 6 2019, 12:59 AM

jhb marked an inline comment as done.Jun 7 2019, 3:48 PM

Closed by commit rS348778: Enable memory and I/O decoding in PCI devices on demand. (authored by jhb). · Explain WhyJun 7 2019, 3:48 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 7 2019, 3:48 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_emul.c

12 lines

Diff 58285

View Options

Enable memory and I/O decoding in PCI devices on demand.ClosedPublicActions