Differential D20488

Fix comment in sofree() to reference sbdestroy().
ClosedPublic
Actions

Authored by jhb on May 31 2019, 10:19 PM.

Tags

None

Referenced Files

	F171559273: D20488.id58134.diff
	Fri, Sep 11, 6:27 PM

	F171464936: D20488.id58134.diff
	Fri, Sep 11, 6:30 AM

	Unknown Object (File)
	Wed, Sep 9, 6:50 PM

	Unknown Object (File)
	Tue, Sep 8, 8:59 PM

	Unknown Object (File)
	Tue, Sep 8, 1:07 AM

	Unknown Object (File)
	Sun, Sep 6, 10:10 AM

	Unknown Object (File)
	Sun, Sep 6, 12:51 AM

	Unknown Object (File)
	Sat, Sep 5, 1:16 PM

Subscribers

Details

Reviewers

rwatson

Commits

rS349475: Fix comment in sofree() to reference sbdestroy().

Summary

r160875 added sbdestroy() as a wrapper around sbrelease_internal to
be called from sofree(), yet the comment added in the same revision
to sofree() still mentions sbrelease_internal().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.May 31 2019, 10:19 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 31 2019, 10:19 PM

Harbormaster completed remote builds in B24640: Diff 58134.May 31 2019, 10:19 PM

Other parts of this comment are a bit rotted and need updating. For example, we now invoke pru_detach() and dom_dispose() before this comment. That means the last paragraph is now wrong / obsolete and needs to be removed I think. Not clear if the calls to pru_detach and dom_dispose should be below this comment or not.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 27 2019, 10:50 PM

Closed by commit rS349475: Fix comment in sofree() to reference sbdestroy(). (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS349475: Fix comment in sofree() to reference sbdestroy()..