Page MenuHomeFreeBSD

posixshmcontrol(1) page
ClosedPublic

Authored by kib on May 27 2019, 5:41 PM.

Details

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib created this revision.May 27 2019, 5:41 PM
danfe added a subscriber: danfe.May 27 2019, 5:48 PM
danfe added inline comments.
usr.bin/posixshmcontrol/posixshmcontrol.1
36 ↗(On Diff #57960)

Shouldn't POSIX be capitalized here, since it's an abbreviation? E.g. re_format(7) spells it correctly. Ditto the one below.

65 ↗(On Diff #57960)

Native speakers may need to correct me here, but IMHO it should be plural contents in this case.

71 ↗(On Diff #57960)

... displayed by the subcommand.

119 ↗(On Diff #57960)

Native speaker's advice needed, but probably To show the contents ... here.

emaste added inline comments.May 27 2019, 6:14 PM
usr.bin/posixshmcontrol/posixshmcontrol.1
36 ↗(On Diff #57960)

Yes.

41 ↗(On Diff #57960)

Where does this come from? AFAICT most man pages just use literal ... and a few \&...

65 ↗(On Diff #57960)

I would say:

It allows inspecting existing segments, dumping their metadata or contents, and unlinking them.

However I think uncountable noun (content) works too, the content of the existing segments.

68 ↗(On Diff #57960)

the system (or the file system)

73–75 ↗(On Diff #57960)

This sentence is a little confusing, maybe break into two?

kib marked 8 inline comments as done.May 27 2019, 6:25 PM
kib updated this revision to Diff 57962.

Handle feedback.

emaste accepted this revision.May 29 2019, 12:57 PM

Ok, LGTM; I'm not an expert on man page markup but can be adjusted after commit if needed.

This revision is now accepted and ready to land.May 29 2019, 12:57 PM
This revision was automatically updated to reflect the committed changes.