Page MenuHomeFreeBSD

DTrace: create an amd64 test suit
ClosedPublic

Authored by oshogbo on May 22 2019, 7:49 PM.

Details

Summary

Create two tests checking if we can read urgs registers and if the
rax register returns a correct number.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

oshogbo created this revision.May 22 2019, 7:49 PM
markj added inline comments.May 22 2019, 8:21 PM
cddl/contrib/opensolaris/cmd/dtrace/test/tst/amd64/arrays/tst.rax.c
32 ↗(On Diff #57719)

Add rax to the clobber list?

oshogbo updated this revision to Diff 57721.May 22 2019, 8:49 PM

Address @markj suggestions.

oshogbo marked an inline comment as done.May 22 2019, 8:50 PM
markj added inline comments.May 22 2019, 9:11 PM
cddl/contrib/opensolaris/cmd/dtrace/test/tst/amd64/arrays/tst.rax.d
29 ↗(On Diff #57721)

The ident pragma shouldn't be added to new files.

oshogbo updated this revision to Diff 57725.May 22 2019, 9:14 PM

Remove pragma.

oshogbo marked an inline comment as done.May 22 2019, 9:15 PM
oshogbo updated this revision to Diff 57727.May 22 2019, 9:20 PM

Remove pragma 2.

markj accepted this revision.May 22 2019, 9:52 PM

Thanks for doing this.

This revision is now accepted and ready to land.May 22 2019, 9:52 PM
This revision was automatically updated to reflect the committed changes.
Herald added 1 blocking reviewer(s): gnn. · View Herald TranscriptJun 5 2019, 10:32 PM
Herald added a subscriber: imp. · View Herald Transcript