Page MenuHomeFreeBSD

Fix gateway setup for the interface routes.
ClosedPublic

Authored by melifaro on May 20 2019, 11:32 PM.
Tags
None
Referenced Files
F172602376: D20328.id.diff
Sat, Sep 19, 2:59 PM
Unknown Object (File)
Sat, Sep 19, 10:59 AM
Unknown Object (File)
Mon, Sep 7, 8:16 AM
Unknown Object (File)
Sun, Sep 6, 7:15 PM
Unknown Object (File)
Sun, Sep 6, 12:58 AM
Unknown Object (File)
Sat, Sep 5, 3:01 PM
Unknown Object (File)
Fri, Sep 4, 8:03 AM
Unknown Object (File)
Wed, Sep 2, 2:17 PM
Subscribers

Details

Summary

Currently rinit1() and its IPv6 counterpart nd6_prefix_onlink_rtrequest() uses dummy null_sdl gateway address during route insertion and fill it afterwards. One of the original reasons might reside in the concern that sizeof(struct sockadd_dl) is rather big to be on-stack (54 bytes on amd64).
Inserting fake gateway and silently fixing it afterwards brings complications to the routing stack.

This change fixes both rinit1() and nd6_prefix_onlink_rtrequest() by filling in proper gateway prior to the inserion. It does not change any of the userland notifications as in both cases, they happen after the insertion and fixup process (rt_newaddrmsg_fib() and nd6_rtmsg())

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable