Page MenuHomeFreeBSD

Fix gateway setup for the interface routes.
ClosedPublic

Authored by melifaro on May 20 2019, 11:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 9:11 PM
Unknown Object (File)
Feb 28 2024, 7:16 PM
Unknown Object (File)
Dec 20 2023, 1:19 AM
Unknown Object (File)
Sep 12 2023, 2:39 AM
Unknown Object (File)
Jun 29 2023, 12:40 PM
Unknown Object (File)
Jun 29 2023, 12:40 PM
Unknown Object (File)
Jun 29 2023, 12:40 PM
Unknown Object (File)
Jun 29 2023, 12:28 PM
Subscribers

Details

Summary

Currently rinit1() and its IPv6 counterpart nd6_prefix_onlink_rtrequest() uses dummy null_sdl gateway address during route insertion and fill it afterwards. One of the original reasons might reside in the concern that sizeof(struct sockadd_dl) is rather big to be on-stack (54 bytes on amd64).
Inserting fake gateway and silently fixing it afterwards brings complications to the routing stack.

This change fixes both rinit1() and nd6_prefix_onlink_rtrequest() by filling in proper gateway prior to the inserion. It does not change any of the userland notifications as in both cases, they happen after the insertion and fixup process (rt_newaddrmsg_fib() and nd6_rtmsg())

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24344
Build 23166: arc lint + arc unit