Page MenuHomeFreeBSD

Add a (q)uit option to the subr_blist test program.
ClosedPublic

Authored by dougm on May 10 2019, 8:51 PM.
Tags
None
Referenced Files
F133501917: D20234.diff
Sun, Oct 26, 6:18 AM
Unknown Object (File)
Sat, Oct 25, 2:56 PM
Unknown Object (File)
Thu, Oct 16, 11:45 AM
Unknown Object (File)
Thu, Oct 16, 11:45 AM
Unknown Object (File)
Thu, Oct 16, 11:45 AM
Unknown Object (File)
Thu, Oct 16, 12:01 AM
Unknown Object (File)
Thu, Oct 2, 4:11 AM
Unknown Object (File)
Wed, Oct 1, 11:44 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  1. Please do not forget about the context for phab patches (-U99999999).
  2. Please explain why this option is needed. For me it looks not too quiet, since the printf() at the beginning of the loop is still vocal.

If I use -U999999, I get one giant diff that I can't apply with 'patch' without collisions if anything changes. I thought -U15 was good enough, once.

Why is this needed? So that the test program isn't an infinite loop.

Why is this objectionable?

If I use -U999999, I get one giant diff that I can't apply with 'patch' without collisions if anything changes. I thought -U15 was good enough, once.

You only use that diff for upload to phab.

Why is this needed? So that the test program isn't an infinite loop.

Oh, I misread quit as quiet. Sorry.

Why is this objectionable?

It is in no way objectionable, I only try to understand your changes.

This revision is now accepted and ready to land.May 10 2019, 9:58 PM
This revision was automatically updated to reflect the committed changes.