Page MenuHomeFreeBSD

Add a (q)uit option to the subr_blist test program.
ClosedPublic

Authored by dougm on May 10 2019, 8:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 27 2024, 8:35 AM
Unknown Object (File)
Sep 18 2024, 7:08 PM
Unknown Object (File)
Sep 17 2024, 10:54 PM
Unknown Object (File)
Sep 1 2024, 12:47 PM
Unknown Object (File)
Aug 30 2024, 7:39 PM
Unknown Object (File)
Aug 30 2024, 7:38 PM
Unknown Object (File)
Aug 30 2024, 7:38 PM
Unknown Object (File)
Aug 30 2024, 7:27 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  1. Please do not forget about the context for phab patches (-U99999999).
  2. Please explain why this option is needed. For me it looks not too quiet, since the printf() at the beginning of the loop is still vocal.

If I use -U999999, I get one giant diff that I can't apply with 'patch' without collisions if anything changes. I thought -U15 was good enough, once.

Why is this needed? So that the test program isn't an infinite loop.

Why is this objectionable?

If I use -U999999, I get one giant diff that I can't apply with 'patch' without collisions if anything changes. I thought -U15 was good enough, once.

You only use that diff for upload to phab.

Why is this needed? So that the test program isn't an infinite loop.

Oh, I misread quit as quiet. Sorry.

Why is this objectionable?

It is in no way objectionable, I only try to understand your changes.

This revision is now accepted and ready to land.May 10 2019, 9:58 PM
This revision was automatically updated to reflect the committed changes.