Page MenuHomeFreeBSD

Start testing cloned interfaces
AbandonedPublic

Authored by ryan_freqlabs.com on May 6 2019, 6:49 AM.

Details

Reviewers
None
Group Reviewers
tests
network
Summary

Tests for cloned interfaces such as lagg and vlan have existed for a while but are not currently enabled. The entire sys/net test suite is not built and installed with the tests dist set, but even if it were, there are many test cases that are set to be skipped because they quickly panic the system. These panics are serious problems that need to be fixed and continuously tested moving forward to prevent regressions in the future.

Enable the existing sys/net tests. Missing tests for epair interfaces have been added, as well.

Sponsored by: iXsystems

Test Plan

Test early, test often.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ryan_freqlabs.com added a comment.EditedMay 6 2019, 6:59 AM

Perhaps the panics currently requiring tests to be skipped should be fixed before the skipped tests are enabled. Multicast cleanup is pending in the following revisions that I am aware of:
https://reviews.freebsd.org/D19886
https://reviews.freebsd.org/D20070

D19886 at least fixes the if_freemulti: protospec not NULL panics (but currently introduces a memory leak). I have not yet tested with D20070.

ryan_freqlabs.com added a comment.EditedMay 6 2019, 7:04 AM

I should also note that there are panics in the lagg tests, described in bugzilla here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234135

kristof added a subscriber: kristof.May 6 2019, 3:48 PM

That seems like a good idea. I'll try to bring it up during the BSDCan devsummit.

asomers added a subscriber: asomers.May 6 2019, 4:06 PM

Definitely do not enable any panicing tests unless you're certain that the panic is fixed. A panic will ruin the entire test run.

There are sadly still a lot of panics triggered by these tests.

It may be worth splitting off the bits that add the epair tests, because we should be able to commit that. Those tests look to be stable.

ryan_freqlabs.com abandoned this revision.Jun 1 2019, 11:52 PM

I have created a new revision for just the epair tests here: https://reviews.freebsd.org/D20498