Page MenuHomeFreeBSD

Restore x18 in efi_arch_leave
ClosedPublic

Authored by andrew on May 1 2019, 4:04 PM.

Details

Summary

Some UEFI implementations trash this register and, as we use it as
a platform register, the kernel doesn't save it before calling into
the UEFI runtime services. As we have a copy in tpidr_el1 restore from
there when exiting the EFI environment.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Move loading x18 before we use it.

Also :

Tested On: Ampere eMAG

This revision is now accepted and ready to land.May 1 2019, 4:31 PM

Should we add a Sponsored by: Ampere Computing (hardware)?

(And Andy's Sponsored-by, of course)

This revision was automatically updated to reflect the committed changes.