Page MenuHomeFreeBSD
Differential D20127

Restore x18 in efi_arch_leave
ClosedPublic
Actions

Authored by andrew on May 1 2019, 4:04 PM.
Tags
None
Referenced Files
F154802553: D20127.diff
Wed, Apr 29, 11:52 AM
F154765225: D20127.id56909.diff
Wed, Apr 29, 9:51 AM
F154631065: D20127.diff
Wed, Apr 29, 2:22 AM
F154484444: D20127.diff
Tue, Apr 28, 5:47 PM
Unknown Object (File)
Mon, Apr 27, 4:08 PM
Unknown Object (File)
Mon, Apr 27, 5:08 AM
Unknown Object (File)
Sat, Apr 25, 8:54 AM
Unknown Object (File)
Fri, Apr 24, 10:21 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
manu
Group Reviewers
arm64
Commits
rS352395: MFC r346996:
rS346996: Restore x18 in efi_arch_leave.
Summary

Some UEFI implementations trash this register and, as we use it as
a platform register, the kernel doesn't save it before calling into
the UEFI runtime services. As we have a copy in tpidr_el1 restore from
there when exiting the EFI environment.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.May 1 2019, 4:04 PM
Herald added a subscriber: emaste. · View Herald TranscriptMay 1 2019, 4:04 PM
Harbormaster completed remote builds in B24037: Diff 56909.May 1 2019, 4:04 PM
andrew updated this revision to Diff 56913.May 1 2019, 4:23 PM

Move loading x18 before we use it.

Harbormaster completed remote builds in B24038: Diff 56913.May 1 2019, 4:23 PM
manu accepted this revision as: manu.May 1 2019, 4:31 PM

Also :

Tested On: Ampere eMAG

This revision is now accepted and ready to land.May 1 2019, 4:31 PM
emaste added a comment.May 1 2019, 4:49 PM

Should we add a Sponsored by: Ampere Computing (hardware)?

emaste added a comment.May 1 2019, 4:51 PM

And PRs 237234, 237055

manu added a comment.May 1 2019, 4:57 PM

Yes (for both)

emaste added a comment.May 1 2019, 5:08 PM

(And Andy's Sponsored-by, of course)

Closed by commit rS346996: Restore x18 in efi_arch_leave. (authored by andrew). · Explain WhyMay 1 2019, 5:13 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptMay 1 2019, 5:13 PM
emaste added a comment.Jun 18 2019, 7:58 PM

Related links courtesy of Ed Vielmetti:
https://bugzilla.tianocore.org/show_bug.cgi?id=625
https://github.com/tianocore/edk2/commit/6d73863b5464f382af2a17b2c2ec1abc550d0af5

andrew added a commit: rS352395: MFC r346996:.Sep 16 2019, 1:45 PM

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
arm64/
10 lines

Diff 56916

View Options

head/sys/arm64/arm64/efirt_machdep.c

Loading...