Differential D2003

Do not strip crunched binary; it will be done by install
ClosedPublic
Actions

Authored by emaste on Mar 3 2015, 4:45 PM.

Details

Reviewers

andrew
imp
adrian
bdrewery

Commits

rS306497: crunchgen: do not strip crunched binary (it will be done by install)

Summary

In cross-build cases it is possible we won't have a cross-strip during the the rescue build. Binaries are already stripped on install anyhow, so there is no need to strip during the build.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 4092.Mar 3 2015, 4:45 PM

emaste retitled this revision from to Do not strip crunched binary; it will be done by install.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: andrew, imp.

emaste added a subscriber: Unknown Object (MLST).

Looks good to me.

This revision is now accepted and ready to land.Mar 3 2015, 10:57 PM

How is install(1) executed? What controls "stripping" via install(1) is the STRIP make variable, so if I set that to null, won't that also avoid stripping crunched binaries? Is that expected?

In D2003#7, @rpaulo wrote:

How is install(1) executed? What controls "stripping" via install(1) is the STRIP make variable, so if I set that to null, won't that also avoid stripping crunched binaries? Is that expected?

Isn't it? If I set STRIP= to avoid stripping binaries, that should apply to the crunched binaries too, shouldn't it?