Differential D1990

Make ofwbus as a subclass of simplebus.
ClosedPublic
Actions

Authored by • ian on Mar 1 2015, 10:45 AM.

Details

Reviewers

nwhitehorn
andrew
imp
mmel
• ian

Summary

Remove duplicated code from ofwbus.c.
Move all useful methods into simplebus.c.
Remove excluded names/types handling.
Don't display devices without "compatible" property in simplebus_probe_nomatch().

Test Plan

This patch is tested on ARM platform only. Please, test it on other platforms too...

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mmel updated this revision to Diff 4045.Mar 1 2015, 10:45 AM

mmel retitled this revision from to Make ofwbus as a subclass of simplebus..

mmel updated this object.

mmel edited the test plan for this revision. (Show Details)

mmel added reviewers: • ian, nwhitehorn, imp, andrew.

mmel set the repository for this revision to rS FreeBSD src repository - subversion.

mmel added a subscriber: jchandra.

imp accepted this revision.Mar 1 2015, 5:01 PM

imp edited edge metadata.

This revision is now accepted and ready to land.Mar 1 2015, 5:01 PM

Generally looks OK but see inline comment about cpufreq.

sys/dev/ofw/ofwbus.c
100	Why is this here? This will break cpufreq on PowerPC.

imp added inline comments.Mar 4 2015, 11:12 PM

sys/dev/ofw/ofwbus.c
100	I'd love to see these all go away...

nwhitehorn added inline comments.Mar 5 2015, 5:39 AM

sys/dev/ofw/ofwbus.c
100	There's actually no need for them. All they do if left is make verbose dmesg a little more verbose and fill up the output of devinfo with a handful of pointless entries.