This port is based on a new uefi-edk2 branch bhyve/edk2-stable201903 made by D Scott Phillips.
The main purpose of this -devel port is to allow us to broadly test the new bhyve uefi firmware till the original one can be replaced.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 23669 Build 22646: arc lint + arc unit
Event Timeline
| sysutils/uefi-edk2-bhyve-devel/Makefile | ||
|---|---|---|
| 6 | We should probably use the gYYYYMMDD format here instead of a version, as described in Example 5.13. of https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html . | |
| 45 | Might want to add a tab here to line it up with the other lines. | |
| 51 | Could we use GH_SUBDIR to specify where the openssl checkout goes instead? | |
| 53 | Might make sense to add another ${LN} line below to symlink python instead of modifying the files here. | |
| 59 | Maybe change "FreeBSD-amd64" to "FreeBSD-${MACHINE}" ? | |
| 60 | Probably want to change all the 8 to ${GCC_DEFAULT} so it works with newer versions too (we specify GCC 8+ above). | |
| 79 | Could you copy OVMF_CODE.fd and also OVMF_VARS.fd here, please? | |
| 83 | I don't think we're supposed to have any lines after .include <bsd.port.mk>, though when I tested it the RUN_DEPENDS line removed, the CSM build failed. | |
Comment Actions
I already did - I reported the results to the freebsd-virtualization mailing list. Everything worked fine except for the CSM build, which is currently crashing when trying to call into the legacy BIOS.
Comment Actions
Aside from Makefile formatting questions, this looks fine to me and makes a working UEFI binary for me.
| sysutils/uefi-edk2-bhyve-devel/Makefile | ||
|---|---|---|
| 83 | We definitely don't want gcc listed as a runtime dependency for this firmware package. Looking at bsd.gcc.mk, I don't see a built in way to opt out of the dependency. | |
| sysutils/uefi-edk2-bhyve-devel/Makefile | ||
|---|---|---|
| 5 | The prefix of 'v' looks a bit strange without a version number now, so might want to consider removing it. | |
| sysutils/uefi-edk2-bhyve-devel/Makefile | ||
|---|---|---|
| 21 | extra backslash here | |
| 53 | building the port now fails for me with /bin/sh: python: not found Fixing it this way seems reasonable: http://ix.io/1Gj3 | |
| sysutils/uefi-edk2-bhyve-devel/Makefile | ||
|---|---|---|
| 29–30 | Remove ${PREFIX}/. | |
| 42 | Wrong place in the Makefile. Should happen before options. See Chapter 15. Order of Variables in Port Makefiles. | |
| 48 | Remove, not needed. | |
| sysutils/uefi-edk2-bhyve-devel/pkg-descr | ||
| 2 | pkg-descr should be at least a couple of lines long. | |