Page MenuHomeFreeBSD

Exercise some care before sending SIGHUP to mountd.
ClosedPublic

Authored by kib on Apr 8 2019, 3:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 11:19 AM
Unknown Object (File)
Fri, Sep 4, 7:42 PM
Unknown Object (File)
Mon, Aug 24, 6:48 PM
Unknown Object (File)
Mon, Aug 24, 6:48 PM
Unknown Object (File)
Mon, Aug 24, 6:45 PM
Unknown Object (File)
Wed, Aug 19, 5:50 PM
Unknown Object (File)
Wed, Aug 19, 3:31 PM
Unknown Object (File)
Wed, Aug 12, 4:07 PM
Subscribers

Details

Summary

Do trivial checks for the mountd' pid validity before.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Could we (also) add assertions in pidfile_open for this case?

sbin/mount/mount.c
243–244 ↗(On Diff #55945)

This comment is historically correct, but really we should stop having such bugs - in any case, we don't expect to have more and the comment suggests it's just something that happens occasionally and we're powerless to stop.

I would probably say "has happened due to ..."

This revision is now accepted and ready to land.Apr 8 2019, 3:52 PM
This revision now requires review to proceed.Apr 8 2019, 3:58 PM
This revision is now accepted and ready to land.Apr 8 2019, 4:40 PM
This revision was automatically updated to reflect the committed changes.