Differential D1982

Fix return errors in tcp_usrreq.c
ClosedPublic
Actions

Authored by harrison-astrodog.net on Feb 27 2015, 6:33 PM.

Details

Reviewers

glebius
jch
gnn
adrian

Summary

tcp_usrreq.c returns incorrect error codes in some cases.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196035 for details

harrison-astrodog.net added a reviewer: jch.Feb 27 2015, 9:07 PM

gnn accepted this revision.Feb 27 2015, 9:23 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Feb 27 2015, 9:23 PM

adrian accepted this revision.Feb 27 2015, 9:25 PM

adrian edited edge metadata.

Revert overenthusiastic error changes.

This revision now requires review to proceed.Mar 1 2015, 3:17 PM

I agree with this patch

sys/netinet/tcp_usrreq.c
464	Minor comment: You can remove the parenthesises: if (inp->inp_flags & INP_TIMEWAIT) {

harrison-astrodog.net edited edge metadata.Mar 1 2015, 9:00 PM

harrison-astrodog.net added a subscriber: Unknown Object (MLST).

jch accepted this revision.Mar 1 2015, 9:04 PM

jch edited edge metadata.

This revision is now accepted and ready to land.Mar 1 2015, 9:04 PM

And I second on jch@ comment.

Remove needless ()s.

This revision now requires review to proceed.Mar 3 2015, 4:41 PM

jch accepted this revision.Mar 3 2015, 4:52 PM

jch edited edge metadata.

This revision is now accepted and ready to land.Mar 3 2015, 4:52 PM

jmg edited edge metadata.Mar 5 2015, 6:32 PM

jmg removed a subscriber: Unknown Object (MLST).

Fix pushed here: https://svnweb.freebsd.org/base?view=revision&revision=279821

jch closed this revision.May 15 2015, 12:36 PM

Change MFC-ed in stable/10 here rS282968: MFC r279821:. Closing this revision.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_usrreq.c

16 lines

Diff 4091

View Options

Fix return errors in tcp_usrreq.cClosedPublicActions