Page MenuHomeFreeBSD

vn_vmap_seekhole(): align running offset to the block boundary.
ClosedPublic

Authored by kib on Apr 3 2019, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 1:10 AM
Unknown Object (File)
Wed, Dec 25, 9:38 AM
Unknown Object (File)
Thu, Dec 12, 7:26 PM
Unknown Object (File)
Oct 2 2024, 10:06 AM
Unknown Object (File)
Oct 1 2024, 7:46 AM
Unknown Object (File)
Sep 30 2024, 11:53 AM
Unknown Object (File)
Sep 25 2024, 8:56 PM
Unknown Object (File)
Sep 25 2024, 7:05 PM
Subscribers

Details

Summary

Otherwise we might miss the last iteration where EOF appears below unaligned noff.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/kern/vfs_vnops.c
2171 ↗(On Diff #55776)

Shouldn't it be noff += noff % bsize == 0 ? bsize : bsize - noff % bsize? Or even noff += bsize - noff % bsize.

Fix invalid calculation of realignment.

This revision is now accepted and ready to land.Apr 4 2019, 11:06 PM
This revision was automatically updated to reflect the committed changes.