Page MenuHomeFreeBSD

Handle ro remount of tmpfs rw mount.
ClosedPublic

Authored by kib on Mar 28 2019, 3:55 PM.

Details

Summary

In particular:

  • suspend the mount around vflush() to avoid new writes come after the vnode is processed
  • flush pending metadata updates (mostly node times)
  • remap all rw mappings of files from the mount into ro (this is not clear to me how to handle best, might be revoke the mapping at all)
  • disable metadata updates after the mp is ro

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 23349

Event Timeline

At the moment this is FYI, the patch is the work in progress. Most important, it handles things I know are broken already, but complete audit of tmpfs is needed to identify the rest of it.

Looks good to my VFS-naive eye. Thanks!

This revision is now accepted and ready to land.Mar 28 2019, 5:36 PM

Update diff to the fixed committable version.

This revision now requires review to proceed.Apr 2 2019, 1:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2019, 1:41 PM
This revision was automatically updated to reflect the committed changes.