Page MenuHomeFreeBSD

Followup to PR231977: Mention that /etc/pf.conf must be created first
ClosedPublic

Authored by bcr on Mar 10 2019, 4:50 PM.

Details

Summary

This is a followup change to address PR 231977: we need to mention that /etc/pf.conf does not exist by default.

I'm having a bit of trouble coming up with a proper change/wording in /head/libexec/rc/rc.conf. Removing the line

pf_rules="/etc/pf.conf"         # rules definition file for pf

would be wrong, as it still is the default location for the file, even if it does not exist there by default. What would be a good way to say that in the comment? Something like

pf_rules="/etc/pf.conf"         # rules definition file for pf (nonexistent by default)

maybe?

Test Plan
  1. Apply the patch to share/man/man5/pf.conf.5
  2. See how it looks like: man ./share/man/man5/pf.conf.5

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bcr created this revision.Mar 10 2019, 4:50 PM
0mp added a subscriber: 0mp.Mar 10 2019, 7:29 PM

pf_rules="/etc/pf.conf" # rules definition file for pf (nonexistent by default)

seems fine.

share/man/man5/pf.conf.5
3056 ↗(On Diff #54897)

How about The file has to be created manually as it is not installed with a standard installation.

bcr updated this revision to Diff 54904.Mar 10 2019, 7:50 PM

Update pf.conf.5 with suggestions from @0mp.

kristof accepted this revision.Mar 12 2019, 10:07 AM
This revision is now accepted and ready to land.Mar 12 2019, 10:07 AM
This revision was automatically updated to reflect the committed changes.