Page MenuHomeFreeBSD

Unbreak manual UART settings (hw.uart.console) on aarch64
AbandonedPublic

Authored by val_packett.cool on Mar 7 2019, 8:54 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Sep 30, 12:52 PM
Unknown Object (File)
Sun, Sep 20, 1:44 PM
Unknown Object (File)
Sun, Sep 20, 5:47 AM
Unknown Object (File)
Thu, Sep 10, 1:11 AM
Unknown Object (File)
Tue, Sep 8, 10:37 PM
Unknown Object (File)
Tue, Sep 8, 4:41 PM
Unknown Object (File)
Tue, Sep 8, 3:17 PM
Unknown Object (File)
Tue, Sep 8, 12:40 AM

Details

Reviewers
andrew
Group Reviewers
Contributor Reviews (src)
Summary

uart_getenv sets di->bas.bst = uart_bus_space_mem;

uart_cpu_getdev sets uart_bus_space_mem = di->bas.bst;

So it was passing the garbage uninitialized value back and forth… and I was wondering why the manually configured PCI UART on the AWS EC2 a1 (Graviton) was not working. (The UART there should be configured via ACPI, but to debug that, I needed a UART in the first place.)

Let's initialize the correct value for the memory space, similar to bus_space_tag_t uart_bus_space_mem = X86_BUS_SPACE_MEM; on amd64.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped