Page MenuHomeFreeBSD

Unbreak manual UART settings (hw.uart.console) on aarch64
AbandonedPublic

Authored by val_packett.cool on Mar 7 2019, 8:54 PM.
Tags
Referenced Files
F150703082: D19502.diff
Fri, Apr 3, 11:53 AM
Unknown Object (File)
Tue, Mar 31, 1:05 AM
Unknown Object (File)
Mon, Mar 30, 1:56 AM
Unknown Object (File)
Sun, Mar 29, 8:58 PM
Unknown Object (File)
Fri, Mar 27, 10:20 PM
Unknown Object (File)
Tue, Mar 24, 6:51 PM
Unknown Object (File)
Tue, Mar 17, 10:46 PM
Unknown Object (File)
Sun, Mar 15, 2:02 AM

Details

Reviewers
andrew
Group Reviewers
Contributor Reviews (src)
Summary

uart_getenv sets di->bas.bst = uart_bus_space_mem;

uart_cpu_getdev sets uart_bus_space_mem = di->bas.bst;

So it was passing the garbage uninitialized value back and forth… and I was wondering why the manually configured PCI UART on the AWS EC2 a1 (Graviton) was not working. (The UART there should be configured via ACPI, but to debug that, I needed a UART in the first place.)

Let's initialize the correct value for the memory space, similar to bus_space_tag_t uart_bus_space_mem = X86_BUS_SPACE_MEM; on amd64.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped