Page MenuHomeFreeBSD
Differential D19491

Document that cal(1) may not start a week with Monday
ClosedPublic
Actions

Authored by 0mp on Mar 7 2019, 9:53 AM.
Tags
None
Referenced Files
F139693523: D19491.id54794.diff
Sun, Dec 14, 11:21 PM
Unknown Object (File)
Mon, Dec 8, 4:55 PM
Unknown Object (File)
Wed, Dec 3, 10:52 PM
Unknown Object (File)
Thu, Nov 27, 10:12 PM
Unknown Object (File)
Sat, Nov 22, 2:33 AM
Unknown Object (File)
Mon, Nov 17, 6:11 PM
Unknown Object (File)
Mon, Nov 17, 5:25 PM
Unknown Object (File)
Mon, Nov 17, 4:15 PM
View All Files
Subscribers
imp

Details

Reviewers
bcr
eadler
Group Reviewers
manpages
Commits
rS344874: Document that cal(1) cannot start a week with Monday.
Summary
Document that cal(1) may not start a week with Monday

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22929
Build 22012: arc lint + arc unit

Event Timeline

0mp created this revision.Mar 7 2019, 9:53 AM
Herald added a reviewer: manpages. · View Herald TranscriptMar 7 2019, 9:53 AM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B22929: Diff 54794.Mar 7 2019, 9:53 AM
0mp updated this revision to Diff 54795.Mar 7 2019, 9:54 AM

Fix a typo

Harbormaster completed remote builds in B22930: Diff 54795.Mar 7 2019, 9:54 AM
bcr accepted this revision.Mar 7 2019, 9:59 AM

Some countries start their week on Sunday, so I guess cal originated there and does not take other countries into account.
That being said, the change itself looks fine. Bumping the .Dd for this content change not withstanding. ;-)

This revision is now accepted and ready to land.Mar 7 2019, 9:59 AM
0mp updated this revision to Diff 54796.Mar 7 2019, 10:00 AM

Reference cal in ports as it offers a way to display Mondays first.

This revision now requires review to proceed.Mar 7 2019, 10:00 AM
Harbormaster completed remote builds in B22931: Diff 54796.Mar 7 2019, 10:00 AM
bcr added a comment.Mar 7 2019, 10:04 AM
This comment was removed by bcr.
bcr accepted this revision.Mar 7 2019, 10:12 AM

This newer version is better as it gives an alternative for people who need that Monday-starts-the-week functionality. Approved!

This revision is now accepted and ready to land.Mar 7 2019, 10:12 AM
0mp updated this revision to Diff 54797.Mar 7 2019, 10:15 AM

Clarify

This revision now requires review to proceed.Mar 7 2019, 10:15 AM
Harbormaster completed remote builds in B22932: Diff 54797.Mar 7 2019, 10:15 AM
bcr added a comment.Mar 7 2019, 10:16 AM

Clarify some more.

usr.bin/ncal/ncal.1
207

s/and have/and want to have/

0mp updated this revision to Diff 54798.Mar 7 2019, 10:17 AM

want to have

Harbormaster completed remote builds in B22933: Diff 54798.Mar 7 2019, 10:17 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2019, 10:19 AM
Closed by commit rS344874: Document that cal(1) cannot start a week with Monday. (authored by 0mp). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
ncal/
5 lines

Diff 54794

View Options

usr.bin/ncal/ncal.1

Loading...