Page MenuHomeFreeBSD
Differential D19279

ix(4): Fix SRIOV initialization
Needs ReviewPublic
Actions

Authored by piotr.pietruszewski_intel.com on Feb 21 2019, 11:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 12:29 AM
Unknown Object (File)
Dec 24 2023, 4:48 PM
Unknown Object (File)
Dec 20 2023, 3:33 AM
Unknown Object (File)
Dec 10 2023, 11:15 PM
Unknown Object (File)
Nov 26 2023, 2:41 PM
Unknown Object (File)
Aug 24 2023, 12:05 AM
Unknown Object (File)
Aug 14 2023, 8:56 PM
Unknown Object (File)
Jul 12 2023, 7:46 PM
View All 15 Files
Subscribers
ae
erj
freqlabs

Details

Reviewers
erj
Group Reviewers
Intel Networking
Summary

This patch fixes SRIOV initialization by moving enabling of SRIOV
feature flag before ixgbe_if_init() is called. Also, Clear To Send flag
will not be added to MBX message when PF sends reset request to VF.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22638
Build 21746: arc lint + arc unit

Event Timeline

piotr.pietruszewski_intel.com created this revision.Feb 21 2019, 11:32 AM
Herald added a subscriber: ae. · View Herald TranscriptFeb 21 2019, 11:32 AM
Harbormaster completed remote builds in B22638: Diff 54179.Feb 21 2019, 11:32 AM
piotr.pietruszewski_intel.com added a reviewer: Intel Networking.Feb 21 2019, 11:33 AM
freqlabs added a subscriber: freqlabs.Feb 23 2019, 3:32 AM
erj added a subscriber: erj.Mar 2 2019, 12:38 AM

Does this match what the Linux PF driver does?

piotr.pietruszewski_intel.com added a comment.Mar 4 2019, 9:36 AM

Partially. Linux driver does not add IXGBE_VT_MSGTYPE_CTS flag while responding to VF reset message. However, IXGBE_FEATURE_SRIOV flag is FreeBSD specific. It is used in ixgbe_if_init() ( https://github.com/freebsd/freebsd/blob/master/sys/dev/ixgbe/if_ix.c#L3016 ), so it should be set before calling ixgbe_if_init() in context of IOV initialization.

erj accepted this revision as: erj.Mar 7 2019, 6:38 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
ixgbe/
7 lines

Diff 54179

View Options

sys/dev/ixgbe/if_sriov.c

Loading...