Page MenuHomeFreeBSD

ix(4): Fix SRIOV initialization
Needs ReviewPublic

Authored by piotr.pietruszewski_intel.com on Feb 21 2019, 11:32 AM.

Details

Reviewers
erj
Group Reviewers
Intel Networking
Summary

This patch fixes SRIOV initialization by moving enabling of SRIOV
feature flag before ixgbe_if_init() is called. Also, Clear To Send flag
will not be added to MBX message when PF sends reset request to VF.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 22638
Build 21746: arc lint + arc unit

Event Timeline

Does this match what the Linux PF driver does?

Partially. Linux driver does not add IXGBE_VT_MSGTYPE_CTS flag while responding to VF reset message. However, IXGBE_FEATURE_SRIOV flag is FreeBSD specific. It is used in ixgbe_if_init() ( https://github.com/freebsd/freebsd/blob/master/sys/dev/ixgbe/if_ix.c#L3016 ), so it should be set before calling ixgbe_if_init() in context of IOV initialization.