Differential D19279

ix(4): Fix SRIOV initialization
AbandonedPublic
Actions

Authored by ziaee on Feb 21 2019, 11:32 AM.

Details

Reviewers

erj
piotr.pietruszewski_intel.com

Group Reviewers

Intel Networking

Summary

This patch fixes SRIOV initialization by moving enabling of SRIOV
feature flag before ixgbe_if_init() is called. Also, Clear To Send flag
will not be added to MBX message when PF sends reset request to VF.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22638
Build 21746: arc lint + arc unit

Event Timeline

piotr.pietruszewski_intel.com created this revision.Feb 21 2019, 11:32 AM

Herald added a subscriber: ae. · View Herald TranscriptFeb 21 2019, 11:32 AM

Harbormaster completed remote builds in B22638: Diff 54179.Feb 21 2019, 11:32 AM

piotr.pietruszewski_intel.com added a reviewer: Intel Networking.Feb 21 2019, 11:33 AM

freqlabs added a subscriber: freqlabs.Feb 23 2019, 3:32 AM

Does this match what the Linux PF driver does?

Partially. Linux driver does not add IXGBE_VT_MSGTYPE_CTS flag while responding to VF reset message. However, IXGBE_FEATURE_SRIOV flag is FreeBSD specific. It is used in ixgbe_if_init() ( https://github.com/freebsd/freebsd/blob/master/sys/dev/ixgbe/if_ix.c#L3016 ), so it should be set before calling ixgbe_if_init() in context of IOV initialization.

erj accepted this revision as: erj.Mar 7 2019, 6:38 PM

Is this still relevant? Can we merge or close this?

@ziaee yes this is overcome by b6cd053e6da9 no remaining changes are needed from this.

Okay, I am commandeering this revision to close it as overcome by events for the purpose of keeping search results clear. If you think this is an error please commandeer this revision and re-open it. Thanks!

ziaee abandoned this revision.Fri, Sep 4, 10:02 AM