Differential D19192

lang/elixir: update to 1.8.1 and use OTP-21 shim
AbandonedPublic
Actions

Authored by dch on Feb 14 2019, 9:28 AM.

Details

Reviewers

jrm
lwhsu
olgeni
feld

Summary

see D19080 alternate implementation

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 22495
Build 21646: arc lint + arc unit

Event Timeline

dch created this revision.Feb 14 2019, 9:28 AM

Harbormaster completed remote builds in B22495: Diff 53910.Feb 14 2019, 9:28 AM

val_packett.cool added a subscriber: val_packett.cool.Mar 28 2019, 9:48 AM

works very well, will this be committed soon?

hey folks, this is a much simpler patch than Mark's earlier one and it's been working fine for me. Let's ship it if there's no complaints. I will amend the absolute path noted above.

lang/elixir/files/patch-bin_elixir
8	this should be a var here.

lwhsu removed 1 blocking reviewer(s): lwhsu.Apr 15 2019, 10:36 AM

I haven't been using elixir for a while, and I haven't tested this patch. It looks good to me, but I don't think I would explicitly "review" it as I haven't tried it yet.