Page MenuHomeFreeBSD

lang/elixir: Update to 1.8.1
Needs ReviewPublic

Authored by feld on Feb 4 2019, 11:18 PM.
This revision needs review, but all reviewers have resigned.

Details

Reviewers
dch
Summary

Updates elixir to 1.8.1

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22422
Build 21580: arc lint + arc unit

Event Timeline

feld created this revision.Feb 4 2019, 11:18 PM
feld updated this revision to Diff 53591.Feb 4 2019, 11:20 PM

Revert erlang dependency to otp 19

feld updated this revision to Diff 53592.Feb 4 2019, 11:21 PM

Again, but with gusto

feld updated this revision to Diff 53593.Feb 4 2019, 11:21 PM

Last fix...

feld added a subscriber: Erlang.Feb 4 2019, 11:22 PM
feld added a comment.Feb 10 2019, 9:57 PM

I want to update this to Elixir 1.8.1 but it now requires OTP 20

===>  Building for elixir-1.8.1
gmake[1]: Entering directory '/wrkdirs/usr/ports/lang/elixir/work/elixir-1.8.1'
At least Erlang/OTP 20.0 is required to build Elixir
feld updated this revision to Diff 53749.Feb 10 2019, 11:41 PM

Update erlang as required

feld retitled this revision from lang/elixir: Update to 1.8.0 to lang/elixir: Update to 1.8.1.Feb 10 2019, 11:41 PM
feld edited the summary of this revision. (Show Details)
feld updated this revision to Diff 53750.Feb 10 2019, 11:43 PM

Minor change

feld updated this revision to Diff 53751.Feb 11 2019, 12:00 AM

Remove hacks required because I overlooked the Makefile patch

feld added a subscriber: olgeni.Feb 11 2019, 12:01 AM
dch added a subscriber: dch.Feb 14 2019, 8:07 AM
dch added a comment.Feb 14 2019, 8:09 AM

submitted exp-run https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235733 for removing the older OTP versions. Once that's back I'll do one to bump default OTP to 21.2.5.

dch added a comment.Feb 14 2019, 8:39 AM

@feld what about using OTP21_RUN_DEPENDS=${LOCALBASE}/lib/erlang21/bin/erl:lang/erlang-runtime21 and leaving the OTP bump alone in this patch? It would also require a small shim for each of:

/usr/local/lib/elixir/bin/elixir
/usr/local/lib/elixir/bin/elixirc
/usr/local/lib/elixir/bin/iex
/usr/local/lib/elixir/bin/mix
dch added inline comments.Feb 14 2019, 8:50 AM
lang/elixir/Makefile
6

this & distinfo need to be based off 1.7.4 for the diff to apply to ports tree:

commit d8c9fa0228450a21b136754afcd69880c8d84555
Author: olgeni <olgeni@FreeBSD.org>
Date: Fri Oct 26 13:22:17 2018 +0000

Update lang/elixir to version 1.7.4.

Notes:

svn path=/head/; revision=483030
dch requested changes to this revision.Feb 14 2019, 9:19 AM

@feld here's https://git.sr.ht/~dch/ports/commit/0af5618836ea22f68f8c4a0c183dee08c042375b alternative implementation using OTP21 via shim, much tidier IMO. I am not clear how to update LOCALBASE within the patch file though, what do you suggest for doing that rather than having it hardwired?

This revision now requires changes to proceed.Feb 14 2019, 9:19 AM
dch resigned from this revision.May 27 2019, 12:41 PM

dropped as we have D19911 & D19912 which updates the erlang dependency as well

This revision now requires review to proceed.May 27 2019, 12:41 PM