Paths

Table of Contentst

Fix reporting errors with `gai_strerror(..)`
ClosedPublic
Actions

Authored by ngie on Jan 25 2019, 7:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 31, 12:00 AM

	Unknown Object (File)
	Dec 20 2025, 5:01 AM

	Unknown Object (File)
	Dec 20 2025, 3:18 AM

	Unknown Object (File)
	Dec 18 2025, 1:16 AM

	Unknown Object (File)
	Dec 2 2025, 11:05 AM

	Unknown Object (File)
	Nov 20 2025, 9:34 PM

	Unknown Object (File)
	Nov 20 2025, 9:34 PM

	Unknown Object (File)
	Nov 20 2025, 9:34 PM

View All Files

Subscribers

imp

Details

Reviewers

asomers
emaste
jtl
lwhsu

Commits

rS343461: Fix reporting errors with `gai_strerror(..)`

Summary

The return value (err) should be checked; not the errno value.

PR: 235200
MFC after: 28 days
MFC with: r343362, r343365, r343367, r343368

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Jan 25 2019, 7:51 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 25 2019, 7:51 PM

Harbormaster completed remote builds in B22161: Diff 53222.Jan 25 2019, 7:51 PM

asomers accepted this revision.Jan 25 2019, 8:07 PM

This revision is now accepted and ready to land.Jan 25 2019, 8:07 PM

LGTM, thanks!

Approved

Closed by commit rS343461: Fix reporting errors with `gai_strerror(..)` (authored by ngie). · Explain WhyJan 26 2019, 3:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

tests/

sys/

sendfile_test.c

2 lines

Diff 53237

View Options

head/lib/libc/tests/sys/sendfile_test.c

Fix reporting errors with `gai_strerror(..)`ClosedPublicActions