Temporarily mark lib.msun.{cbrt_test.cbrtl_powl,trig_test.reduction} expected failure after clang700-import merge
ClosedPublic
Actions

Authored by lwhsu on Jan 24 2019, 4:33 AM.

Details

Reviewers

dim
emaste
markj
ngie

Commits

rS343442: Temporarily mark lib.msun.{cbrt_test.cbrtl_powl,trig_test.reduction}

Summary

Temporarily mark lib.msun.{cbrt_test.cbrtl_powl,trig_test.reduction}
expected failure after clang700-import merge

PR: 234040

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lwhsu created this revision.Jan 24 2019, 4:33 AM

Herald added a reviewer: ngie. · View Herald TranscriptJan 24 2019, 4:33 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B22109: Diff 53139.Jan 24 2019, 4:33 AM

This skips testing on all architectures and compilers.

It would make more sense (and I should have done this before), to do something along the lines of:

#if defined(__amd64__) && defined(__clang__) && __clang_major__ > 7
    atf_tc_expect_fail("test fails with clang 7+ - bug 234040");
#endif

This revision now requires changes to proceed.Jan 24 2019, 5:23 AM

Mark expected failure only on amd64 with clang7+

Harbormaster completed remote builds in B22110: Diff 53142.Jan 24 2019, 7:49 AM

Macro like:

This revision is now accepted and ready to land.Jan 25 2019, 1:00 AM

Approved

Closed by commit rS343442: Temporarily mark lib.msun.{cbrt_test.cbrtl_powl,trig_test.reduction} (authored by lwhsu). · Explain WhyJan 25 2019, 6:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

contrib/

netbsd-tests/

lib/

libm/

t_cbrt.c

4 lines

lib/

msun/

tests/

trig_test.c

4 lines

Diff 53217

View Options

head/contrib/netbsd-tests/lib/libm/t_cbrt.c