Page MenuHomeFreeBSD

Clarify unsupported architecture upgrade message
ClosedPublic

Authored by aryeeteygerald_rogers.com on Jan 21 2019, 7:27 PM.

Details

Summary

Notify users that upgrading from any arch other than
amd64 and i386 is unsupported by freebsd-update.

PR: 204115

Test Plan

None

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 22070
Build 21298: arc lint + arc unit

Event Timeline

emaste added a subscriber: gordon.
emaste added inline comments.
usr.sbin/freebsd-update/freebsd-update.sh
689–690

FreeBSD shell style places the cases at the same indentation level as the case statement itself:

case $... in
a | b)
        cmd
        ;;
c)
        cmd2
        ;;
esac
delphij requested changes to this revision.Jan 22 2019, 5:10 AM

I really don't like this approach because it would bar us from retrofit publishing freebsd-update bits (and would create problems for users who have their own freebsd-update instance running). I think it's more appropriate to make fetch_key to provide more meaningful output instead of "Fetching public key from ... failed".

This revision now requires changes to proceed.Jan 22 2019, 5:10 AM
  • Fix style issues

Also modify error message slightly

Gerald originally suggested an approach similar to what you describe, but I suggested the simpler way here.

Point well taken, new review will come.

  • Clarify 'mirror failure' message

Update exiting error message to report potential cause and solution.

It would be preferable to exit earlier by searching in some sort of support list
as suggested by @emaste but this should hopefully suffice until then.

I suggest s/can be/can only be/ .

LGTM & Thanks for your work!

This revision is now accepted and ready to land.Jan 24 2019, 5:50 AM
This revision was automatically updated to reflect the committed changes.